Index: [Article Count Order] [Thread]

Date:  Tue, 18 Apr 2006 03:09:32 +0900
From:  Hisao SHIBUYA <shibuya (at mark) alpha.or.jp>
Subject:  [coba-e:04719] Re: bugfix CMU
To:  coba-e (at mark) bluequartz.org
Message-Id:  <0352DC42-4744-4247-9C15-08BF6FEE40F1 (at mark) alpha.or.jp>
In-Reply-To:  <20060416213906.M16642 (at mark) scargo.nl>
References:  <20060416213906.M16642 (at mark) scargo.nl>
X-Mail-Count: 04719

Hi Taco,

Thank you for your patch.
I commit your patch and put new package into testing repository now.

I fixed this issue for RaQ550, 5100R, TLAS1HE and TLAS2.

Hisao


On 2006/04/17, at 6:39, Taco Scargo wrote:

> Hisao (and other interested parties),
>
> After reading some user comments about cmu not importing siteadmins,
> I spent quite some time figuring out why CMU did not do what it  
> should do
> (when importing a RaQ4 cmu export).
> After adding some additional debugging info cmu suddenly started  
> working.
> After I removed the additional 'warn' statements, it stopped  
> working again.
>
> I finally found out (by removing lines one by one) that the problem  
> was
> introduced due to the fact that the 5100Radjust.pl script converts  
> a raq4
> cmu.xml file to a raq550 compatible cmu.xml file.
>
> To be precise:
>
> <admin value = "t"/>
>
> needs to be converted to:
>
> <capLevels>
>   <cap>siteAdmin</cap>
> </capLevels>
>
> The current code forces the value $oldVal to become a string,  
> whereas the
> data could become an array (<cap> inside of <capLevels>).
>
> By commenting out the my $oldVal everything works as expected.
>
> See the diff -u below:
>
> --- 5100Radjust.pl.orig 2006-04-16 22:14:16.000000000 +0200
> +++ 5100Radjust.pl      2006-04-16 23:15:39.000000000 +0200
> @@ -238,7 +238,7 @@
>         }
>         if(defined $remapData{$class}) {
>                 my $remapHash = $remapData{$class};
> -               my $oldVal;
> +#              my $oldVal;
>                 foreach my $name (keys %{ $remapHash }) {
>                         next if(!defined $hash->{$name});
>                         $oldVal = $hash->{$name};
>
>
> Hisao, can you please implement this in the cmu code and push out  
> an updated
> CMU rpm ?
>
> If other people have encountered other problems with cmu, please  
> let me know
> so I can have a look at these problems as well. Due to the  
> debugging I did
> this weekend I think I am quite 'into cmu' now....
>
> Thanks,
>
> Taco